Messages in this thread | | | Date | Fri, 15 May 2009 14:31:11 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH] ata: libata depends on HAS_DMA |
| |
FUJITA Tomonori wrote: > On Wed, 13 May 2009 17:57:14 -0600 > Robert Hancock <hancockrwd@gmail.com> wrote: > >> Alan Cox wrote: >>>>> If it doesn't interfere with plain PIO mode, fine. >>>> I agree. There definitely needs to still be support for IDE ports that >>>> don't have DMA capability. >>> There is - it's just if the platform doesn't implement the dma_* APIs you >>> get a problem. >> Wouldn't the easiest solution be to just dummy out the DMA API calls on >> this platform to always fail? That would fix these compile problems.. > > Can libata call dma_supported() per device to decide DMA or PIO mode? > Then, we can solve this problem by add dummy DMA API (just calls BUG) > on such architectures, without Kconfig magic or adding ifdef (like the > old ide stack does), I think.
Sure it can. Which specific drivers are we talking about?
Thanks.
-- tejun
| |