| Date | Thu, 02 Apr 2009 14:48:56 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH 22/43] CacheFiles: Add a hook to write a single page of data to an inode [ver #46] |
| |
David Howells wrote: > Add an address space operation to write one single page of data to an inode at > a page-aligned location (thus permitting the implementation to be highly > optimised). The data source is a single page. > > diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c > index b43b955..5d17070 100644 > --- a/fs/ext2/inode.c > +++ b/fs/ext2/inode.c > @@ -817,6 +817,8 @@ const struct address_space_operations ext2_nobh_aops = { > .direct_IO = ext2_direct_IO, > .writepages = ext2_writepages, > .migratepage = buffer_migrate_page, > + .write_one_page = generic_file_buffered_write_one_page, > + .write_one_page = generic_file_buffered_write_one_page Adding the same function pointer twice seems a bit excessive.
Other than that, the patch looks good :)
|