[lkml]   [2009]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 22/43] CacheFiles: Add a hook to write a single page of data to an inode [ver #46]
On Fri, Apr 03, 2009 at 02:32:58AM +1100, Nick Piggin wrote:
> Hmm, I guess not all filesystems define write_begin/write_end. But if you
> only need to use ones that do define them?

No. write_begin/write_end are simply callbacks for the write helpers,
and locking for them is entirely filesystem-defined. E.g. xfs and the
cluster filesystems require additional locks taken first, and some
network filesystems require inode revalidations first.

They really should be taken out of the address_space_operations and
passed as callbacks to generic_file_aio_write & co.

 \ /
  Last update: 2009-04-02 18:41    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean