Messages in this thread | | | Date | Fri, 6 Feb 2009 19:35:42 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] i2c: add missing KERN_* constants to printks |
| |
Hello,
On Fri, Feb 06, 2009 at 02:45:14PM +0100, Frank Seidel wrote: > From: Frank Seidel <frank@f-seidel.de> > > According to kerneljanitors todo list all printk calls (beginning > a new line) should have an according KERN_* constant. > Those are the missing pieces here for the i2c subsystem. OK in principle. Still *I* prefer the pr_debug, pr_emerg etc. macros. Looks a bit nicer ...
> --- a/drivers/i2c/algos/i2c-algo-pca.c > +++ b/drivers/i2c/algos/i2c-algo-pca.c > @@ -51,7 +51,7 @@ static int i2c_debug; > static void pca_start(struct i2c_algo_pca_data *adap) > { > int sta = pca_get_con(adap); > - DEB2("=== START\n"); > + DEB2(KERN_WARNING "=== START\n"); Are you sure about KERN_WARNING? I havn't looked deeper, but DEB2 suggests KERN_DEBUG? What about fixing DEB[1-3] directly instead of each "call". e.g.
-#define DEB2(fmt, args...) do { if (i2c_debug>=2) printk(fmt, ## args); } while(0) +#define DEB2(fmt, args...) do { if (i2c_debug>=2) pr_warning(fmt, ## args); } while(0)
Best regards, Uwe
| |