lkml.org 
[lkml]   [2009]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i2c: add missing KERN_* constants to printks
On Sun, 08 Feb 2009 14:11:52 +0100, Frank Seidel wrote:
> Hi,
>
> Jean Delvare wrote:
> >> + printk(KERN_ERR "i2c: ICR: %08x ISR: %08x\n"
> >> "i2c: log: ", readl(_ICR(i2c)), readl(_ISR(i2c)));
> >> for (i = 0; i < i2c->irqlogidx; i++)
> >> printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]);
> >
> > This last printk also lacks a log level. You can't add it in the loop,
> > but you could add one printk before the loop, printing just the log level.
>
> Isn't the last printk just a followup of the previous KERN_ERR which
> doesn't have a newline? And i'm told only on new line beginnings the
> loglevel should be set.

I mean the (first) printk in the loop, not the last printk in this
function. So what I am suggesting is:

+ printk(KERN_DEBUG);
for (i = 0; i < i2c->irqlogidx; i++)
printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]);
printk("\n");

--
Jean Delvare


\
 
 \ /
  Last update: 2009-02-08 14:51    [W:1.749 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site