lkml.org 
[lkml]   [2009]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCHv2 2/2] i2c: adapt debug macros for KERN_* constants
    From: Frank Seidel <frank@f-seidel.de>

    According to kerneljanitors todo list all printk calls (beginning
    a new line) should have an according KERN_* constant.
    Those are the changes to the debug macros in the i2c subsystem
    to meet this requirement. Also changing no-debug statements
    to raw printks again.

    Signed-off-by: Frank Seidel <frank@f-seidel.de>
    ---
    drivers/i2c/algos/i2c-algo-pca.c | 14 +++++++++-----
    1 file changed, 9 insertions(+), 5 deletions(-)

    --- a/drivers/i2c/algos/i2c-algo-pca.c
    +++ b/drivers/i2c/algos/i2c-algo-pca.c
    @@ -27,9 +27,12 @@
    #include <linux/i2c.h>
    #include <linux/i2c-algo-pca.h>

    -#define DEB1(fmt, args...) do { if (i2c_debug>=1) printk(fmt, ## args); } while(0)
    -#define DEB2(fmt, args...) do { if (i2c_debug>=2) printk(fmt, ## args); } while(0)
    -#define DEB3(fmt, args...) do { if (i2c_debug>=3) printk(fmt, ## args); } while(0)
    +#define DEB1(fmt, args...) do { if (i2c_debug >= 1) \
    + printk(KERN_DEBUG fmt, ## args); } while (0)
    +#define DEB2(fmt, args...) do { if (i2c_debug >= 2) \
    + printk(KERN_DEBUG fmt, ## args); } while (0)
    +#define DEB3(fmt, args...) do { if (i2c_debug >= 3) \
    + printk(KERN_DEBUG fmt, ## args); } while (0)

    static int i2c_debug;

    @@ -313,7 +316,7 @@ static int pca_xfer(struct i2c_adapter *

    ret = curmsg;
    out:
    - DEB1(KERN_CRIT "}}} transfered %d/%d messages. "
    + DEB1("}}} transfered %d/%d messages. "
    "status is %#04x. control is %#04x\n",
    curmsg, num, pca_status(adap),
    pca_get_con(adap));
    @@ -347,7 +350,8 @@ static int pca_init(struct i2c_adapter *
    pca_reset(pca_data);

    clock = pca_clock(pca_data);
    - DEB1(KERN_INFO "%s: Clock frequency is %dkHz\n", adap->name, freqs[clock]);
    + printk(KERN_INFO "%s: Clock frequency is %dkHz\n", adap->name,
    + freqs[clock]);

    pca_set_con(pca_data, I2C_PCA_CON_ENSIO | clock);
    udelay(500); /* 500 us for oscilator to stabilise */

    \
     
     \ /
      Last update: 2009-02-08 15:23    [W:0.022 / U:59.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site