lkml.org 
[lkml]   [2009]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 16/24] HWPOISON: limit hwpoison injector to known page types

* Wu Fengguang <fengguang.wu@intel.com> wrote:

> --- linux-mm.orig/mm/hwpoison-inject.c 2009-11-30 20:44:41.000000000 +0800
> +++ linux-mm/mm/hwpoison-inject.c 2009-11-30 20:58:20.000000000 +0800
> @@ -3,16 +3,41 @@
> #include <linux/debugfs.h>
> #include <linux/kernel.h>
> #include <linux/mm.h>
> +#include <linux/swap.h>
> #include "internal.h"
>
> static struct dentry *hwpoison_dir;
>
> static int hwpoison_inject(void *data, u64 val)
> {

i'd like to raise a continuing conceptual objection against the ad-hoc
and specialistic nature of the event injection in the
mm/memory-failure*.c code. It should probably be using a standardized
interface by integrating with perf events - as i outlined it before.

Where needed perf events should be extended - we can help with that.
There's no point in having scattered pieces of incompatible (and
user-ABI affecting) infrastructure all around the kernel.

Thanks,

Ingo



\
 
 \ /
  Last update: 2009-12-02 09:13    [W:0.391 / U:24.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site