lkml.org 
[lkml]   [2009]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 12/24] HWPOISON: make it possible to unpoison pages
    On Wed, Dec 02, 2009 at 09:15:30PM +0800, Andi Kleen wrote:
    > > Note that it may leak pages silently - those who have been removed from
    > > LRU cache, but not isolated from page cache/swap cache at hwpoison time.
    >
    > It would be better if we could detect that somehow and at least warn.
    >
    > > }
    > >
    > > +static int hwpoison_forget(void *data, u64 val)
    > > +{
    > > + if (!capable(CAP_SYS_ADMIN))
    > > + return -EPERM;
    > > +
    > > + return forget_memory_failure(val);
    > > +}
    > > +
    > > DEFINE_SIMPLE_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n");
    > > +DEFINE_SIMPLE_ATTRIBUTE(unpoison_fops, NULL, hwpoison_forget, "%lli\n");
    >
    > I'll rename it to unpoison, not forget. I think that's a more clear
    > name.

    OK. Will repost the whole updated patchset.

    Thanks,
    Fengguang


    \
     
     \ /
      Last update: 2009-12-02 14:35    [from the cache]
    ©2003-2011 Jasper Spaans