lkml.org 
[lkml]   [2009]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/24] HWPOISON: abort on failed unmap
On Wed, Dec 02, 2009 at 09:11:50PM +0800, Andi Kleen wrote:
> > * Now take care of user space mappings.
> > + * Abort on fail: __remove_from_page_cache() assumes unmapped page.
> > */
> > - hwpoison_user_mappings(p, pfn, trapno);
> > + if (hwpoison_user_mappings(p, pfn, trapno) != SWAP_SUCCESS) {
> > + res = -EBUSY;
> > + goto out;
>
> It would be good to print something in this case.

OK.

> Did you actually see it during testing?

Perhaps not.

> Or maybe loop forever in the unmapper.

!SWAP_SUCCESS should be rare, so not necessary to loop forever?

Thanks,
Fengguang



\
 
 \ /
  Last update: 2009-12-02 14:31    [W:0.081 / U:28.536 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site