Messages in this thread | | | From | David Brownell <> | Subject | Re: [PATCH] genirq: warn about IRQF_SHARED|IRQF_DISABLED at the right place | Date | Mon, 30 Nov 2009 12:21:30 -0800 |
| |
On Monday 30 November 2009, Uwe Kleine-König wrote: > + if (new->flags & IRQF_DISABLED) > + pr_warning("IRQ %d/%s: IRQF_DISABLED is not guaranteed " > + "on shared IRQs\n", irq, new->name);
This should have copied the original test ... this way, it's dropping the SHARED constraint, and trying to morph into a generic "IRQF_DISABLED is eeebil!" test.
If it just moved the original test, I'd have no problem with the patch.
... although it'd still not address the general mess in this area, it'd at least not introduce false warnings. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |