Messages in this thread Patch in this message |  | | From | Uwe Kleine-König <> | | Subject | [PATCH] warn about shared irqs requesting IRQF_DISABLED registered with setup_irq | | Date | Fri, 27 Nov 2009 22:10:06 +0100 |
| |
IRQF_DISABLED is not guaranteed on shared irqs. There is already a warning in place for irqs registered with request_irq (introduced in 470c66239ef03). Move it to __setup_irq, this way it triggers for both request_irq and setup_irq.
One irq that is now warned about is the timer tick on at91 (ARCH=arm).
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: David Brownell <dbrownell@users.sourceforge.net> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Ingo Molnar <mingo@elte.hu> Cc: Nicolas Pitre <nico@marvell.com> Cc: Eric Miao <eric.y.miao@gmail.com> Cc: John Stultz <johnstul@us.ibm.com> Cc: Rusty Russell <rusty@rustcorp.com.au> Cc: Remy Bohmer <linux@bohmer.net>, Cc: Hugh Dickins <hugh.dickins@tiscali.co.uk>, Cc: Andrea Gallo <andrea.gallo@stericsson.com>, Cc: Thomas Gleixner <tglx@linutronix.de>, Cc: linux-arm-kernel@lists.infradead.org --- kernel/irq/manage.c | 26 +++++++++++++------------- 1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index bde4c66..59f4b54 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -613,6 +613,19 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) int nested, shared = 0; int ret; + /* + * handle_IRQ_event() always ignores IRQF_DISABLED except for + * the _first_ irqaction (sigh). That can cause oopsing, but + * the behavior is classified as "will not fix" so we need to + * start nudging drivers away from using that idiom. + */ + if ((new->flags & (IRQF_SHARED|IRQF_DISABLED)) == + (IRQF_SHARED|IRQF_DISABLED)) { + pr_warning( + "IRQ %d/%s: IRQF_DISABLED is not guaranteed on shared IRQs\n", + irq, new->name); + } + if (!desc) return -EINVAL; @@ -1008,19 +1021,6 @@ int request_threaded_irq(unsigned int irq, irq_handler_t handler, struct irq_desc *desc; int retval; - /* - * handle_IRQ_event() always ignores IRQF_DISABLED except for - * the _first_ irqaction (sigh). That can cause oopsing, but - * the behavior is classified as "will not fix" so we need to - * start nudging drivers away from using that idiom. - */ - if ((irqflags & (IRQF_SHARED|IRQF_DISABLED)) == - (IRQF_SHARED|IRQF_DISABLED)) { - pr_warning( - "IRQ %d/%s: IRQF_DISABLED is not guaranteed on shared IRQs\n", - irq, devname); - } - #ifdef CONFIG_LOCKDEP /* * Lockdep wants atomic interrupt handlers: -- 1.6.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |