[lkml]   [2009]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[patch 18/46] pkt_sched: sch_htb: Fix deadlock in hrtimers triggered by HTB
2.6.28-stable review patch.  If anyone has any objections, please let us know.

From: Jarek Poplawski <>

[ Upstream commit: none

This is a quick fix for -stable purposes. Upstream fixes these
problems via a large set of invasive hrtimer changes. ]

Most probably there is a (still unproven) race in hrtimers (before
2.6.29 kernels), which causes a corruption of hrtimers rbtree. This
patch doesn't fix it, but should let HTB avoid triggering the bug.

Reported-by: Denys Fedoryschenko <>
Reported-by: Badalian Vyacheslav <>
Reported-by: Chris Caputo <>
Tested-by: Badalian Vyacheslav <>
Signed-off-by: Jarek Poplawski <>
Signed-off-by: David S. Miller <>
Signed-off-by: Greg Kroah-Hartman <>

net/sched/sch_htb.c | 1 +
1 file changed, 1 insertion(+)
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -924,6 +924,7 @@ static struct sk_buff *htb_dequeue(struc
+ qdisc_watchdog_cancel(&q->watchdog);
qdisc_watchdog_schedule(&q->watchdog, next_event);
return skb;

 \ /
  Last update: 2009-01-23 02:23    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean