Messages in this thread Patch in this message | | | Date | Thu, 22 Jan 2009 17:11:53 -0800 | From | Greg KH <> | Subject | [patch 13/46] ALSA: hda - Dont reset HP pinctl in patch_sigmatel.c |
| |
2.6.28-stable review patch. If anyone has any objections, please let us know.
------------------
From: Takashi Iwai <tiwai@suse.de>
commit 8317e0b0c2234f5f1f5d54804e4093d11bc0dffa upstream.
Resetting HP pinctl at the unplugged state may cause a sort of regression on some devices because of their wrong pin configuration.
A simple workaround is to disable the pin reset. This is ugly and may be not good from the power-saving POV (if any), but damn simple.
Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- sound/pci/hda/patch_sigmatel.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
--- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -3985,8 +3985,19 @@ static void stac92xx_hp_detect(struct hd continue; if (presence) stac92xx_set_pinctl(codec, cfg->hp_pins[i], val); +#if 0 /* FIXME */ +/* Resetting the pinctl like below may lead to (a sort of) regressions + * on some devices since they use the HP pin actually for line/speaker + * outs although the default pin config shows a different pin (that is + * wrong and useless). + * + * So, it's basically a problem of default pin configs, likely a BIOS issue. + * But, disabling the code below just works around it, and I'm too tired of + * bug reports with such devices... + */ else stac92xx_reset_pinctl(codec, cfg->hp_pins[i], val); +#endif /* FIXME */ } }
| |