lkml.org 
[lkml]   [2009]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 29/46] netfilter: ebtables: fix inversion in match code
    2.6.28-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Patrick McHardy <kaber@trash.net>

    Upstream commit d61ba9f:

    Commit 8cc784ee (netfilter: change return types of match functions
    for ebtables extensions) broke ebtables matches by inverting the
    sense of match/nomatch.

    Reported-by: Matt Cross <matthltc@us.ibm.com>
    Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/bridge/netfilter/ebtables.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/bridge/netfilter/ebtables.c
    +++ b/net/bridge/netfilter/ebtables.c
    @@ -80,7 +80,7 @@ static inline int ebt_do_match (struct e
    {
    par->match = m->u.match;
    par->matchinfo = m->data;
    - return m->u.match->match(skb, par);
    + return m->u.match->match(skb, par) ? EBT_MATCH : EBT_NOMATCH;
    }

    static inline int ebt_dev_check(char *entry, const struct net_device *device)


    \
     
     \ /
      Last update: 2009-01-23 02:27    [W:0.020 / U:29.832 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site