Messages in this thread | | | Date | Fri, 22 Aug 2008 14:48:08 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [RFC][PATCH -mm 6/7] memcg: make-mapping-null-before-calling-uncharge.patch |
| |
On Fri, 22 Aug 2008 13:57:43 +0900 Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
> > @@ -379,6 +377,15 @@ static void migrate_page_copy(struct pag > > ClearPagePrivate(page); > > set_page_private(page, 0); > > page->mapping = NULL; > You forget to remove this line :) > Ouch, thanks. -Kame
> Thanks, > Daisuke Nishimura. > > > + /* page->mapping contains a flag for PageAnon() */ > > + if (PageAnon(page)) { > > + /* This page is uncharged at try_to_unmap(). */ > > + page->mapping = NULL; > > + } else { > > + /* Obsolete file cache should be uncharged */ > > + page->mapping = NULL; > > + mem_cgroup_uncharge_cache_page(page); > > + } > > > > /* > > * If any waiters have accumulated on the new page then > > >
| |