lkml.org 
[lkml]   [2008]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH -mm 6/7] memcg: make-mapping-null-before-calling-uncharge.patch
> @@ -379,6 +377,15 @@ static void migrate_page_copy(struct pag
> ClearPagePrivate(page);
> set_page_private(page, 0);
> page->mapping = NULL;
You forget to remove this line :)

Thanks,
Daisuke Nishimura.

> + /* page->mapping contains a flag for PageAnon() */
> + if (PageAnon(page)) {
> + /* This page is uncharged at try_to_unmap(). */
> + page->mapping = NULL;
> + } else {
> + /* Obsolete file cache should be uncharged */
> + page->mapping = NULL;
> + mem_cgroup_uncharge_cache_page(page);
> + }
>
> /*
> * If any waiters have accumulated on the new page then
>


\
 
 \ /
  Last update: 2008-08-22 07:05    [W:0.099 / U:10.760 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site