Messages in this thread | | | Date | Wed, 13 Aug 2008 09:51:59 +0900 | Subject | Re: [PATCH 0/7] x86 dma_*_coherent rework patchset | From | FUJITA Tomonori <> |
| |
On Tue, 12 Aug 2008 17:24:10 +0200 Joerg Roedel <joerg.roedel@amd.com> wrote:
> Hi, > > this patchset reworks the dma_*_coherent functions in the DMA layer for the x86 > architecture. The patch series extends the existing DMA backends with missing > *coherent callbacks and simplifies the generic function to basically only call > the registered backend. This allows future optimizations in hardware specific > IOMMU implementations. > The code ist tested on AMD64 with AMD IOMMU and GART as well as on my old 486 > box. It is not yet tested on a Calgary IOMMU system. > > Joerg > > git diff --stat tip/master: > > arch/x86/kernel/amd_iommu.c | 2 - > arch/x86/kernel/pci-calgary_64.c | 14 +++++ > arch/x86/kernel/pci-dma.c | 116 +++---------------------------------- > arch/x86/kernel/pci-gart_64.c | 31 ++++++++++ > arch/x86/kernel/pci-nommu.c | 45 +++++++++++++++ > 5 files changed, 100 insertions(+), 108 deletions(-)
Really nice. I think that this is how other architectures that support multiple IOMMUs handle dma operations, and this is the right thing for x86 too.
| |