lkml.org 
[lkml]   [2008]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/7] x86: add free_coherent dma_ops callback to GART driver
    On Wed, Aug 13, 2008 at 09:45:53AM +0900, FUJITA Tomonori wrote:
    > On Tue, 12 Aug 2008 17:24:12 +0200
    > Joerg Roedel <joerg.roedel@amd.com> wrote:
    >
    > > Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
    > > ---
    > > arch/x86/kernel/pci-gart_64.c | 10 ++++++++++
    > > 1 files changed, 10 insertions(+), 0 deletions(-)
    > >
    > > diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c
    > > index 55cc388..18db09b 100644
    > > --- a/arch/x86/kernel/pci-gart_64.c
    > > +++ b/arch/x86/kernel/pci-gart_64.c
    >
    > It would be better to foil this to the first patch, I think. Any
    > reasonable reason to add alloc_coherent and free_coherent with two
    > separate patches?

    Yes possible. Its always a bit hard to split the patches correctly. Some
    maintainers prefer small patches and for others its split up too much
    then. If I am in doubt I often chose to split a patch.

    > I think that you can remove map_simple in gart (and please don't
    > forget to remove map_simple in struct dma_mapping_ops. I think only
    > GART uses that hook).

    Ok, I will check that and send a sperate patch.

    Joerg

    --
    | AMD Saxony Limited Liability Company & Co. KG
    Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
    System | Register Court Dresden: HRA 4896
    Research | General Partner authorized to represent:
    Center | AMD Saxony LLC (Wilmington, Delaware, US)
    | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy



    \
     
     \ /
      Last update: 2008-08-13 14:53    [W:0.025 / U:16.600 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site