Messages in this thread | | | Date | Wed, 13 Aug 2008 09:45:51 +0900 | Subject | Re: [PATCH 6/7] x86: cleanup dma_*_coherent functions | From | FUJITA Tomonori <> |
| |
On Tue, 12 Aug 2008 17:24:16 +0200 Joerg Roedel <joerg.roedel@amd.com> wrote:
> All dma_ops implementations support the alloc_coherent and free_coherent > callbacks now. This allows a big simplification of the dma_alloc_coherent > function which is done with this patch. The dma_free_coherent functions is also > cleaned up and calls now the free_coherent callback of the dma_ops > implementation. > > Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> > --- > arch/x86/kernel/pci-dma.c | 116 ++++----------------------------------------- > 1 files changed, 10 insertions(+), 106 deletions(-) > > diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c > index f704cb5..60fa80d 100644 > --- a/arch/x86/kernel/pci-dma.c > +++ b/arch/x86/kernel/pci-dma.c
How about moving dma_free_coherent and dma_alloc_coherent to asm-x86/dma-mapping.h? It would be nice to have all the dma operations in one place.
| |