lkml.org 
[lkml]   [2008]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/18] ide: use ->tf_load in actual_try_to_identify()
Hello.

Bartlomiej Zolnierkiewicz wrote:
> Convert actual_try_to_identify() to use ->tf_load instead of ->OUTB.
>
> There should be no functional changes caused by this patch.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
[...]
> Index: b/drivers/ide/ide-probe.c
> ===================================================================
> --- a/drivers/ide/ide-probe.c
> +++ b/drivers/ide/ide-probe.c
> @@ -290,9 +290,15 @@ static int actual_try_to_identify (ide_d
> /* set features register for atapi
> * identify command to be sure of reply
> */
> - if ((cmd == WIN_PIDENTIFY))
> - /* disable dma & overlap */
> - hwif->OUTB(0, io_ports->feature_addr);
> + if (cmd == WIN_PIDENTIFY) {
> + ide_task_t task;
> +
> + memset(&task, 0, sizeof(task));
> + /* disable DMA & overlap */
> + task.tf_flags = IDE_TFLAG_OUT_FEATURE;
> +
> + drive->hwif->tf_load(drive, &task);
> + }
>

Eww, this is bulky but should be a part of your plan to switch to
tf_load() method...

WBR, Sergei




\
 
 \ /
  Last update: 2008-06-21 01:17    [W:0.236 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site