| Date | Sat, 21 Jun 2008 03:14:30 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 12/18] ide: use ->tf_load in actual_try_to_identify() |
| |
Hello.
Bartlomiej Zolnierkiewicz wrote: > Convert actual_try_to_identify() to use ->tf_load instead of ->OUTB. > > There should be no functional changes caused by this patch. > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > [...] > Index: b/drivers/ide/ide-probe.c > =================================================================== > --- a/drivers/ide/ide-probe.c > +++ b/drivers/ide/ide-probe.c > @@ -290,9 +290,15 @@ static int actual_try_to_identify (ide_d > /* set features register for atapi > * identify command to be sure of reply > */ > - if ((cmd == WIN_PIDENTIFY)) > - /* disable dma & overlap */ > - hwif->OUTB(0, io_ports->feature_addr); > + if (cmd == WIN_PIDENTIFY) { > + ide_task_t task; > + > + memset(&task, 0, sizeof(task)); > + /* disable DMA & overlap */ > + task.tf_flags = IDE_TFLAG_OUT_FEATURE; > + > + drive->hwif->tf_load(drive, &task); > + } >
Eww, this is bulky but should be a part of your plan to switch to tf_load() method...
WBR, Sergei
|