| Date | Sat, 21 Jun 2008 02:03:16 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 04/18] ide: remove ide_setup_dma() |
| |
Hello.
Bartlomiej Zolnierkiewicz wrote: > Export sff_dma_ops and then remove ide_setup_dma(). > > There should be no functional changes caused by this patch. > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > [...] > Index: b/drivers/ide/arm/palm_bk3710.c > =================================================================== > --- a/drivers/ide/arm/palm_bk3710.c > +++ b/drivers/ide/arm/palm_bk3710.c > @@ -318,15 +318,14 @@ static u8 __devinit palm_bk3710_cable_de > static int __devinit palm_bk3710_init_dma(ide_hwif_t *hwif, > const struct ide_port_info *d) > { > - unsigned long base = > - hwif->io_ports.data_addr - IDE_PALM_ATA_PRI_REG_OFFSET; > - > printk(KERN_INFO " %s: MMIO-DMA\n", hwif->name); > > if (ide_allocate_dma_engine(hwif)) > return -1; > > - ide_setup_dma(hwif, base); > + hwif->dma_base = hwif->io_ports.data_addr - IDE_PALM_ATA_PRI_REG_OFFSET; >
That's er... too complex. Actually, 'base' has the value for 'dma_base' at that moment...
WBR, Sergei
|