lkml.org 
[lkml]   [2008]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2 v2] x86: remove unused function, register the cpu vendor in nexgen.c
Date
Nobody calls the function nexgen_init_cpu(), which is defined
in arch/x86/kernel/cpu/nexgen.c. Therefore this routine can
be removed, and this patch does so.

Additionally, this patch adds the missing registration of the
NexGen CPUs by the cpu_vendor_dev_register() macro.

This patch was build-tested using the defconfig for i386. It
also survived a few randconfig instances. Runtime tests were
performed by booting an i386 box up to the shell prompt.

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
---
Peter,

Thanks for your review. Hopefully this version is OK.

arch/x86/kernel/cpu/nexgen.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/cpu/nexgen.c b/arch/x86/kernel/cpu/nexgen.c
index 5d5e1c1..3117e96 100644
--- a/arch/x86/kernel/cpu/nexgen.c
+++ b/arch/x86/kernel/cpu/nexgen.c
@@ -52,8 +52,4 @@ static struct cpu_dev nexgen_cpu_dev __cpuinitdata = {
.c_identify = nexgen_identify,
};

-int __init nexgen_init_cpu(void)
-{
- cpu_devs[X86_VENDOR_NEXGEN] = &nexgen_cpu_dev;
- return 0;
-}
+cpu_vendor_dev_register(X86_VENDOR_NEXGEN, &nexgen_cpu_dev);
--
1.5.3


\
 
 \ /
  Last update: 2008-04-20 12:35    [W:0.051 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site