lkml.org 
[lkml]   [2008]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] x86: remove unused code and data in nexgen.c
Andi Kleen пишет:
> "H. Peter Anvin" <hpa@zytor.com> writes:
>
>> Dmitri Vorobiev wrote:
>>> Nobody calls the function nexgen_init_cpu(), therefore it
>>> can be removed. The variable nexgen_cpu_dev is used only by
>>> this function, so this patch removes useless data as well.
>>> This patch was build-tested using defconfigs for i386 and x86_64.
>>> It also survived a few randconfig instances for i386. Runtime
>>> tests were performed by booting 32-bit and 64-bit x86 boxen up to
>>> the shell prompt.
>> NAK. This is broken.
>>
>> The reason nexgen_cpu_dev is unreferenced is because the file is
>> missing a cpu_vendor_dev_register(), which should be added.
>
> If we did that long without it wouldn't it be better to just remove it?
>
> Also NexGen was never shipped anyways, but bought by AMD and became
> the K6. So I assume whatever this file is supposed to do is done
> by amd.c anyways.
>

IOW, you claim that now it's safe enough to throw away the NexGen
altogether?

Dmitri

> -Andi
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-04-20 21:27    [W:0.054 / U:3.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site