[lkml]   [2008]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/4] x86: remove unused code and data in nexgen.c
"H. Peter Anvin" <> writes:

> Dmitri Vorobiev wrote:
>> Nobody calls the function nexgen_init_cpu(), therefore it
>> can be removed. The variable nexgen_cpu_dev is used only by
>> this function, so this patch removes useless data as well.
>> This patch was build-tested using defconfigs for i386 and x86_64.
>> It also survived a few randconfig instances for i386. Runtime
>> tests were performed by booting 32-bit and 64-bit x86 boxen up to
>> the shell prompt.
> NAK. This is broken.
> The reason nexgen_cpu_dev is unreferenced is because the file is
> missing a cpu_vendor_dev_register(), which should be added.

If we did that long without it wouldn't it be better to just remove it?

Also NexGen was never shipped anyways, but bought by AMD and became
the K6. So I assume whatever this file is supposed to do is done
by amd.c anyways.


 \ /
  Last update: 2008-04-20 20:55    [W:0.064 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site