Messages in this thread | | | Date | Mon, 25 Feb 2008 23:21:47 +0100 | From | Pavel Machek <> | Subject | Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p) |
| |
On Mon 2008-02-25 16:32:38, Jeff Garzik wrote: > Pavel Machek wrote: >>> commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 >>> Author: Pavel Machek <pavel@ucw.cz> >>> Date: Thu Feb 21 13:56:55 2008 +0100 >>> >>> power_state: get rid of write-only variable in SATA >> >> This is pretty unlikely to be it. Can you double check that this patch >> really breaks something? > > Quote... > > After reverting 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 > on top of 2.6.25-rc3 the kernel again resumes from suspend to > ram. > > Seems pretty clear to me.
Yep, that patch was crappy. I developed it on machine with SCSI powersave patches applied, and did not realize this code changed. Sorry.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |