lkml.org 
[lkml]   [2008]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectCONFIG_MARKERS
    From
    Date
    Yo,

    I notice in module.c:

    #ifdef CONFIG_MARKERS
    if (!mod->taints)
    marker_update_probe_range(mod->markers,
    mod->markers + mod->num_markers, NULL, NULL);
    #endif

    Is this an attempt to not set a marker for proprietary modules? If so,
    then this really should be the following conditional instead, because,
    really we're not guaranteeing there won't be other taints (e.g. in RHEL
    we already have the module signing patch, and then there's also the
    TAINT_FORCED_MODULE, which arguably isn't a "taint" for markers):

    #ifdef CONFIG_MARKERS
    if (!(mod->taints & TAINT_PROPRIETARY_MODULE))
    marker_update_probe_range(mod->markers,
    mod->markers + mod->num_markers, NULL, NULL);
    #endif

    Or am I missing something?

    Jon.




    \
     
     \ /
      Last update: 2008-01-22 20:17    [W:0.020 / U:95.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site