Messages in this thread | | | Subject | CONFIG_MARKERS | From | Jon Masters <> | Date | Tue, 22 Jan 2008 14:13:55 -0500 |
| |
Yo,
I notice in module.c:
#ifdef CONFIG_MARKERS if (!mod->taints) marker_update_probe_range(mod->markers, mod->markers + mod->num_markers, NULL, NULL); #endif
Is this an attempt to not set a marker for proprietary modules? If so, then this really should be the following conditional instead, because, really we're not guaranteeing there won't be other taints (e.g. in RHEL we already have the module signing patch, and then there's also the TAINT_FORCED_MODULE, which arguably isn't a "taint" for markers):
#ifdef CONFIG_MARKERS if (!(mod->taints & TAINT_PROPRIETARY_MODULE)) marker_update_probe_range(mod->markers, mod->markers + mod->num_markers, NULL, NULL); #endif
Or am I missing something?
Jon.
| |