Messages in this thread | | | Date | Tue, 17 Jul 2007 00:12:57 +0200 | From | Heiko Carstens <> | Subject | Re: uninline check_signature() |
| |
On Mon, Jul 16, 2007 at 06:02:55PM +0000, Linux Kernel Mailing List wrote: > Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=cc2ea416b2aa04d0c34ff2281a23dae5b76b7b3b > Commit: cc2ea416b2aa04d0c34ff2281a23dae5b76b7b3b > Parent: 4e7bd66318b3ae60fbba7d886d9a98b71ffbf74e > Author: Andrew Morton <akpm@linux-foundation.org> > AuthorDate: Sun Jul 15 23:41:38 2007 -0700 > Committer: Linus Torvalds <torvalds@woody.linux-foundation.org> > CommitDate: Mon Jul 16 09:05:50 2007 -0700 > > uninline check_signature() > > This is a rather bizarre thing to have inlined in io.h. Stick it in lib/ > instead. > > While we're there, despaghetti it a bit, and fix its off-by-one behaviour when > passed a zero length. > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> > --- > include/linux/io.h | 29 ++--------------------------- > lib/Makefile | 2 +- > lib/check_signature.c | 26 ++++++++++++++++++++++++++ > 3 files changed, 29 insertions(+), 28 deletions(-)
Hmm.. this breaks s390 and probably m68k and UML as well:
CC lib/check_signature.o lib/check_signature.c: In function 'check_signature': lib/check_signature.c:19: error: implicit declaration of function 'readb'
Actually we tried to fix this, but it looks like there was no final conclusion: http://lkml.org/lkml/2007/6/28/98
Now what? Revert until things have been sorted out? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |