Messages in this thread Patch in this message | | | Date | Tue, 17 Jul 2007 01:03:07 +0200 | From | Heiko Carstens <> | Subject | Re: uninline check_signature() |
| |
On Mon, Jul 16, 2007 at 03:35:34PM -0700, Linus Torvalds wrote: > On Mon, 16 Jul 2007, Andrew Morton wrote: > > > > No, no revert, please. If the architecture doesn't support readb() then we > > need some reliable way of working that out within Kconfig. > > Isn't that CONFIG_HAS_IOMEM?
That was my understanding as well considering commits 5ea8176994003483a18c8fed580901e2125f8a83 and 23db764d3db5a4bb1e104ad9310e5dc18e4ffa1b
so the patch below should be correct... Geert, Roman?
Subject: [PATCH] Make check_signature() depend on CONFIG_HAS_IOMEM
From: Heiko Carstens <heiko.carstens@de.ibm.com>
check_signature() uses readb() and therefore should only be build on CONFIG_HAS_IOMEM.
Otherwise breaks s390: lib/check_signature.c: In function `check_signature': lib/check_signature.c:19: error: implicit declaration of function `readb'
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> --- lib/Makefile | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
Index: linux-2.6/lib/Makefile =================================================================== --- linux-2.6.orig/lib/Makefile +++ linux-2.6/lib/Makefile @@ -13,7 +13,7 @@ lib-$(CONFIG_SMP) += cpumask.o lib-y += kobject.o kref.o kobject_uevent.o klist.o obj-y += div64.o sort.o parser.o halfmd4.o debug_locks.o random32.o \ - bust_spinlocks.o hexdump.o check_signature.o + bust_spinlocks.o hexdump.o ifeq ($(CONFIG_DEBUG_KOBJECT),y) CFLAGS_kobject.o += -DDEBUG @@ -21,7 +21,7 @@ CFLAGS_kobject_uevent.o += -DDEBUG endif obj-$(CONFIG_GENERIC_IOMAP) += iomap.o -obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o +obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o check_signature.o obj-$(CONFIG_DEBUG_LOCKING_API_SELFTESTS) += locking-selftest.o obj-$(CONFIG_DEBUG_SPINLOCK) += spinlock_debug.o lib-$(CONFIG_RWSEM_GENERIC_SPINLOCK) += rwsem-spinlock.o - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |