Messages in this thread Patch in this message | | | Subject | Re: checkpatch, a patch checking script. | From | Roland Dreier <> | Date | Fri, 27 Apr 2007 22:58:26 -0700 |
| |
> Use WARN_ON & Recovery code rather than BUG() and BUG_ON() > 23286:+ BUILD_BUG_ON(BCM43xx_SEC_KEYSIZE < ETH_ALEN);
BTW, I missed this before -- BUILD_BUG_ON() is actually far better than WARN_ON(), I think.
Maybe something like this? (Although someone who knows perl probably has a better way)
--- Don't tell people to change BUILD_BUG_ON() to WARN_ON().
Signed-off-by: Roland Dreier <rolandd@cisco.com>
--- checkpatch.pl.orig 2007-04-27 20:30:34.000000000 -0700 +++ checkpatch.pl 2007-04-27 22:54:42.000000000 -0700 @@ -123,7 +123,7 @@ $warnings += search(qr/kernel_thread\(/, "Use kthread abstraction instead of kernel_thread()\n"); $warnings += search(qr/typedef/, "Do not add new typedefs.\n"); $warnings += search(qr/uint32_t/, "Incorrect type usage for kernel code. Use __u32 etc.\n"); - $warnings += search(qr/BUG(_ON)\(/, "Use WARN_ON & Recovery code rather than BUG() and BUG_ON()\n"); + $warnings += search(qr/(?<!BUILD_)BUG(_ON)\(/, "Use WARN_ON & Recovery code rather than BUG() and BUG_ON()\n"); # pedantic: Noisy regexps that aren't really fatal. if ($opt_pedantic) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |