Messages in this thread | | | Date | Thu, 4 May 2006 17:51:25 +0300 | From | "Pekka Enberg" <> | Subject | Re: [PATCH 5/13: eCryptfs] Header declarations |
| |
On 5/4/06, Phillip Hellewell <phillip@hellewell.homeip.net> wrote: > +#ifdef OBSERVE_ASSERTS > +#define ASSERT(EX) \ > +do { \ > + if (unlikely(!(EX))) { \ > + printk(KERN_CRIT "ASSERTION FAILED: %s at %s:%d (%s)\n", #EX, \ > + __FILE__, __LINE__, __FUNCTION__); \ > + BUG(); \ > + } \ > +} while (0) > +#else > +#define ASSERT(EX) ; > +#endif /* OBSERVE_ASSERTS */
So, what's wrong with BUG_ON?
> + > +#define ECRYPTFS_FILE_TO_PRIVATE(file) ((struct ecryptfs_file_info *) \ > + ((file)->private_data)) > +#define ECRYPTFS_FILE_TO_PRIVATE_SM(file) ((file)->private_data) > +#define ECRYPTFS_FILE_TO_LOWER(file) \ > + ((ECRYPTFS_FILE_TO_PRIVATE(file))->wfi_file) > +#define ECRYPTFS_INODE_TO_PRIVATE(ino) ((struct ecryptfs_inode_info *) \ > + (ino)->u.generic_ip) > +#define ECRYPTFS_INODE_TO_PRIVATE_SM(ino) ((ino)->u.generic_ip) > +#define ECRYPTFS_INODE_TO_LOWER(ino) (ECRYPTFS_INODE_TO_PRIVATE(ino)->wii_inode) > +#define ECRYPTFS_SUPERBLOCK_TO_PRIVATE(super) ((struct ecryptfs_sb_info *) \ > + (super)->s_fs_info) > +#define ECRYPTFS_SUPERBLOCK_TO_PRIVATE_SM(super) ((super)->s_fs_info) > +#define ECRYPTFS_SUPERBLOCK_TO_LOWER(super) \ > + (ECRYPTFS_SUPERBLOCK_TO_PRIVATE(super)->wsi_sb) > +#define ECRYPTFS_DENTRY_TO_PRIVATE_SM(dentry) ((dentry)->d_fsdata) > +#define ECRYPTFS_DENTRY_TO_PRIVATE(dentry) ((struct ecryptfs_dentry_info *) \ > + (dentry)->d_fsdata) > +#define ECRYPTFS_DENTRY_TO_LOWER(dentry) \ > + (ECRYPTFS_DENTRY_TO_PRIVATE(dentry)->wdi_dentry)
Static inline functions, please.
> + > +#define ecryptfs_printk(type, fmt, arg...) \ > + __ecryptfs_printk(type "%s: " fmt, __FUNCTION__, ## arg); > +void __ecryptfs_printk(const char *fmt, ...);
Why not plain printk?
> +extern kmem_cache_t *ecryptfs_auth_tok_list_item_cache; > +extern kmem_cache_t *ecryptfs_file_info_cache; > +extern kmem_cache_t *ecryptfs_dentry_info_cache; > +extern kmem_cache_t *ecryptfs_inode_info_cache; > +extern kmem_cache_t *ecryptfs_sb_info_cache; > +extern kmem_cache_t *ecryptfs_header_cache_0; > +extern kmem_cache_t *ecryptfs_header_cache_1; > +extern kmem_cache_t *ecryptfs_header_cache_2; > +extern kmem_cache_t *ecryptfs_lower_page_cache;
Please use struct kmem_cache instead. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |