lkml.org 
[lkml]   [2006]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/13: eCryptfs] Superblock operations
On 5/4/06, Pavel Machek <pavel@suse.cz> wrote:
> HI!
>
> > +/**
> > + * Get the filesystem statistics. Currently, we let this pass right through
> > + * to the lower filesystem and take no action ourselves.
> > + */
> > +static int ecryptfs_statfs(struct super_block *sb, struct kstatfs *buf)
> > +{
> > + int rc = 0;
> > +
> > + ecryptfs_printk(KERN_DEBUG, "Enter\n");
> > + rc = vfs_statfs(ECRYPTFS_SUPERBLOCK_TO_LOWER(sb), buf);
> > + ecryptfs_printk(KERN_DEBUG, "Exit; rc = [%d]\n", rc);
> > + return rc;
> > +}
>
> This is ugly. Could you remove the debugging, or at least use dprintk?

How would dprintk differ from the current approach with ecryptfs_printk?

--
Michael C. Thompson <mcthomps@us.ibm.com>
Software-Engineer, IBM LTC Security
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-04 16:05    [from the cache]
©2003-2011 Jasper Spaans