Messages in this thread | | | Date | Thu, 2 Nov 2006 01:24:09 +0100 | From | "Jesper Juhl" <> | Subject | Re: [KJ][PATCH] Correct misc_register return code handling in several drivers |
| |
On 02/11/06, Randy Dunlap <randy.dunlap@oracle.com> wrote: > On Thu, 2 Nov 2006 01:05:49 +0100 Jesper Juhl wrote: > > > On 01/11/06, Neil Horman <nhorman@tuxdriver.com> wrote: > > > Hey all- > > > Since Andrew hasn't incorporated this patch yet, and I had the time, I > > > redid the patch taking Benjamin's INIT_LIST_HEAD and Joes mmtimer cleanup into > > > account. New patch attached, replacing the old one, everything except the > > > aforementioned cleanups is identical. > > > > > > Thanks & Regards > > > Neil > > > > > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com> > > > > > > +out4: > > > + for_each_online_node(node) { > > > + kfree(timers[node]); > > > + } > > > +out3: > > > + misc_deregister(&mmtimer_miscdev); > > > +out2: > > > + free_irq(SGI_MMTIMER_VECTOR, NULL); > > > +out1: > > > + return -1; > > > > Very nitpicky little thing, but shouldn't the labels start at column > > 1, not column 0 ? > > I thought that was standard practice (apparently labels at column 0 > > can confuse 'patch'). > > > > Hmm, I guess that should be defined once and for all in > > Documentation/CodingStyle > > I have some other CodingStyle changes to submit, but feel free > to write this one up. > > However, I didn't know that we had a known style for this, other > than "not indented so far that it's hidden". > > If a label in column 0 [0-based :] confuses patch, then that's > a reason, I suppose. I wasn't aware of that one... > In a case like that, we usually say "fix the tool then." >
Well, I am not entirely sure what confusion it is supposed to cause, but comments such as this one suggests that there are some known cases: http://lkml.org/lkml/2005/9/16/213 And in addition, it something that I recall having seen lots of comments on on LKML, so I just assumed that there is some truth to it. That is again backed by the circumstantial evidence that many files actually do place labels at column 1 currently.
(lots of hand waving going on here, I know)
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |