Messages in this thread | | | Date | Wed, 1 Nov 2006 16:27:27 -0800 | From | Andrew Morton <> | Subject | Re: [KJ][PATCH] Correct misc_register return code handling in several drivers |
| |
On Wed, 1 Nov 2006 16:11:55 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > Hmm, I guess that should be defined once and for all in > > Documentation/CodingStyle > > I have some other CodingStyle changes to submit, but feel free > to write this one up.
Starting labels in column 2 gives me the creeps, personally. But there's a decent justification for it.
> However, I didn't know that we had a known style for this, other > than "not indented so far that it's hidden". > > If a label in column 0 [0-based :] confuses patch, then that's > a reason, I suppose. I wasn't aware of that one... > In a case like that, we usually say "fix the tool then."
The problem is that `diff -p' screws up and displays the label: in the place where it should be displaying the function name.
Of course, lots of people forget the -p anyway... Maybe we can fix those tools ;) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |