lkml.org 
[lkml]   [2006]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [KJ][PATCH] Correct misc_register return code handling in several drivers
    On Thu, 2 Nov 2006 01:05:49 +0100 Jesper Juhl wrote:

    > On 01/11/06, Neil Horman <nhorman@tuxdriver.com> wrote:
    > > Hey all-
    > > Since Andrew hasn't incorporated this patch yet, and I had the time, I
    > > redid the patch taking Benjamin's INIT_LIST_HEAD and Joes mmtimer cleanup into
    > > account. New patch attached, replacing the old one, everything except the
    > > aforementioned cleanups is identical.
    > >
    > > Thanks & Regards
    > > Neil
    > >
    > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
    > >
    > > +out4:
    > > + for_each_online_node(node) {
    > > + kfree(timers[node]);
    > > + }
    > > +out3:
    > > + misc_deregister(&mmtimer_miscdev);
    > > +out2:
    > > + free_irq(SGI_MMTIMER_VECTOR, NULL);
    > > +out1:
    > > + return -1;
    >
    > Very nitpicky little thing, but shouldn't the labels start at column
    > 1, not column 0 ?
    > I thought that was standard practice (apparently labels at column 0
    > can confuse 'patch').
    >
    > Hmm, I guess that should be defined once and for all in
    > Documentation/CodingStyle

    I have some other CodingStyle changes to submit, but feel free
    to write this one up.

    However, I didn't know that we had a known style for this, other
    than "not indented so far that it's hidden".

    If a label in column 0 [0-based :] confuses patch, then that's
    a reason, I suppose. I wasn't aware of that one...
    In a case like that, we usually say "fix the tool then."

    ---
    ~Randy
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-02 01:21    [W:0.024 / U:0.352 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site