Messages in this thread | | | Date | Mon, 23 May 2005 19:09:02 -0400 | From | Jeff Garzik <> | Subject | Re: enable-reads-on-plextor-712-sa-on-26115.patch added to -mm tree |
| |
akpm@osdl.org wrote: > The patch titled > > Enable reads on Plextor 712-SA on 2.6.11.5 > > has been added to the -mm tree. Its filename is > > enable-reads-on-plextor-712-sa-on-26115.patch > > Patches currently in -mm which might be from andystewart@comcast.net are > > enable-reads-on-plextor-712-sa-on-26115.patch
Andrew -- The use of the word 'hack' didn't trigger any response??
By hardcoding so much of the inquiry data, this patch -overwrites- valid inquiry data provided by the device, with generic data. This patch makes generic the probe data that the SCSI layer -depends on to be different-.
Effectively you made one CD-ROM device work, killed all the others, and enabled an oops generator.
Good show.
Even if this patch worked, you still need to fix the following:
* Patch INQUIRY data -slightly- to fool the SCSI layer into working correctly. This is what Andy's patch [poorly] attempts to address. * Handling DRQ interrupts (early patch exists) * Padding DMA data (50% patch exists) * Fix error handling (patch exists) * Fix all FIS-based drivers so that an error doesn't cause an oops * Implement non-polled REQUEST SENSE error handling for FIS-based drivers
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |