Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: [RFC][PATCH 1/6] RTC subsystem, class | Date | Tue, 20 Dec 2005 21:01:39 -0500 |
| |
Hi,
On Tuesday 20 December 2005 15:45, Alessandro Zummo wrote: > +int rtc_read_time(struct class_device *class_dev, struct rtc_time *tm) > +{ > + int err = -EINVAL; > + struct rtc_class_ops *ops = class_get_devdata(class_dev); > + > + if (ops->read_time) { > + memset(tm, 0, sizeof(struct rtc_time)); >
What guarantees that ops is not NULL here? Userspace can keep the attribute (file) open and issue read after class_device was unregistered and devdata set to NULL.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |