Messages in this thread | | | From | Andries.Brouwer@cwi ... | Date | Thu, 3 Jul 2003 18:25:59 +0200 (MEST) | Subject | Re: [PATCH] cryptoloop |
| |
hch:
> Some nitpicking:
Thanks. In case Linus applied the patch this is unimportant. In case he didnt I'll probably resubmit when 2.5.75 comes out and apply your polishing.
> + if (info->lo_encrypt_type == LO_CRYPT_CRYPTOAPI) > > this special-casing sounds like a bad idea.
True. But it is only in the compatibility code. Once you rip that out the special casing disappears automatically. It describes current reality.
> imho we should rip out the whole concept of transfer functions
They are used much more frequently than cryptoapi is. People tell me jari-loop is much faster at present. If this is true, your move would not be very popular.
Anyway, I am not doing a redesign. Just a cleanup.
Andries - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |