lkml.org 
[lkml]   [2003]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: sys32_ioctl -> compat_ioctl -- generic
    Hi!

    > > +asmlinkage long compat_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg)
    >
    > For consistancy, this should be called compat_sys_ioctl.

    Done. (And moved whole stuff to fs/compat.c).

    > > +{
    > > + struct file * filp;
    >
    > > + filp = fget(fd);
    >
    > > + /* find the name of the device. */
    > > + if (path) {
    > > + struct file *f = fget(fd);
    >
    > Is it really necessary to do another fget(fd) ?

    This is andi's code, but it seems unneeded, fixed.

    > Also, if you are adding this much code, you should add a copyright notice
    > to the top of the file ...

    I actually need to copy copyrights from ia32_ioctl, where I took
    this. Done.
    Pavel
    --
    When do you have a heart between your knees?
    [Johanka's followup: and *two* hearts?]
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:0.021 / U:156.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site