lkml.org 
[lkml]   [2003]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: sys32_ioctl -> compat_ioctl -- generic
Hi!

> > This is generic part of sys32_ioctl -> compat_ioctl. Please apply,
>
> Thanks for this - you saved me a headache :-)

Well, I fear total sum of headache stayed constant ;-).

Anyway, producing these patches seems "easy" compared to actually
merging them. You seem to have some experience with this, would you be
willing to help?


> Some comments:
>
> > --- clean/kernel/compat.c 2003-03-03 23:39:39.000000000 +0100
> > +++ linux/kernel/compat.c 2003-02-20 10:48:21.000000000 +0100
>
> All this really belongs in fs/compat.c ...
>
> One thing that Linus (and I) wanted from the compatability layer is
> to try to keep all 32 bit assumptions out of the generic code - I
> understand that this my not be possible, but we would like to try.
>
> So maybe you could start by changing ioctl32 to compat_ioctl everywhere -
> I know that this is just cosmetic, but it gives the better impression of
> what the code is about ...

I thought about that, but I fear resulting diff would be too big (and
would bitrot extremely quickly). I thought I'd try to merge simple (&
small) stuff first, to see how bit it will be.....

Pavel


--
Horseback riding is like software...
...vgf orggre jura vgf serr.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.084 / U:5.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site