lkml.org 
[lkml]   [2003]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: sys32_ioctl -> compat_ioctl -- generic
Hi Pavel,

On Tue, 4 Mar 2003 00:21:22 +0100 Pavel Machek <pavel@ucw.cz> wrote:
>
> This is generic part of sys32_ioctl -> compat_ioctl. Please apply,

Thanks for this - you saved me a headache :-)

Some comments:

> --- clean/kernel/compat.c 2003-03-03 23:39:39.000000000 +0100
> +++ linux/kernel/compat.c 2003-02-20 10:48:21.000000000 +0100

All this really belongs in fs/compat.c ...

One thing that Linus (and I) wanted from the compatability layer is
to try to keep all 32 bit assumptions out of the generic code - I
understand that this my not be possible, but we would like to try.

So maybe you could start by changing ioctl32 to compat_ioctl everywhere -
I know that this is just cosmetic, but it gives the better impression of
what the code is about ...

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.067 / U:1.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site