lkml.org 
[lkml]   [2002]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: Linux v2.5.32
    On Tue, 27 Aug 2002, Linus Torvalds wrote:

    >...
    > Summary of changes from v2.5.31 to v2.5.32
    > ============================================
    >...
    > Eric Sandeen <sandeen@sgi.com>:
    > o Remove unused var and unused func from ali-ircc IrDA driver
    >...


    This change removes the variable "ret" but not it's use:


    <-- snip -->

    ...
    gcc -Wp,-MD,./.ali-ircc.o.d -D__KERNEL__
    -I/home/bunk/linux/kernel-2.5/linux-2
    .5.32-full/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2
    -fomit-frame-poi
    nter -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
    -march=
    k6 -nostdinc -iwithprefix include -DKBUILD_BASENAME=ali_ircc -c -o
    ali-ircc
    .o ali-ircc.c
    ali-ircc.c: In function `ali_ircc_open':
    ali-ircc.c:286: `ret' undeclared (first use in this function)
    ali-ircc.c:286: (Each undeclared identifier is reported only once
    ali-ircc.c:286: for each function it appears in.)
    ...
    make[3]: *** [ali-ircc.o] Error 1
    make[3]: Leaving directory
    `/home/bunk/linux/kernel-2.5/linux-2.5.32-full/drivers/net/irda'

    <-- snip -->


    -dj contains the following to remove the use of ret:


    --- drivers/net/irda/ali-ircc.c.old 2002-08-28 19:15:38.000000000 +0200
    +++ drivers/net/irda/ali-ircc.c 2002-08-28 19:15:40.000000000 +0200
    @@ -283,15 +283,13 @@
    self->io.fifo_size = 16; /* SIR: 16, FIR: 32 Benjamin 2000/11/1 */

    /* Reserve the ioports that we need */
    - ret = check_region(self->io.fir_base, self->io.fir_ext);
    - if (ret < 0) {
    + if (!request_region(self->io.fir_base, self->io.fir_ext, driver_name)) {
    WARNING(__FUNCTION__ "(), can't get iobase of 0x%03x\n",
    self->io.fir_base);
    dev_self[i] = NULL;
    kfree(self);
    return -ENODEV;
    }
    - request_region(self->io.fir_base, self->io.fir_ext, driver_name);

    /* Initialize QoS for this device */
    irda_init_max_qos_capabilies(&self->qos);

    cu
    Adrian

    --

    You only think this is a free country. Like the US the UK spends a lot of
    time explaining its a free country because its a police state.
    Alan Cox


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:28    [W:0.040 / U:29.652 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site