lkml.org 
[lkml]   [2002]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.5.8 IDE 34
    On Mon, Apr 15 2002, Martin Dalecki wrote:

    Two comments --

    Could you please _not_ just rearrange comments or change style in ide-cd
    just for the sake cleaning, it's very annoying when one has patches that
    need to be adapted every time. And it serves zero purpose. Thanks.

    I changed the CONFIG_BLK_DEV_IDEPCI stuff to always include the pci_dev
    in the hwgroup, and just leave it at NULL if not defined. This cleans up
    some ifdefs, I think this is the better approach.

    I'll sync the latest tcq stuff with you later today, it gets the
    enabling right etc.

    And a last comment not directly related to this particular patch -- when
    you include something and change minor stuff along the way, please do it
    in two steps. One that includes a patch, and a second version that
    changes what you want to change. That makes merging _so_ much easier.
    Thanks.

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:25    [W:0.028 / U:31.688 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site