lkml.org 
[lkml]   [2002]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Various 802.1Q VLAN driver patches.
    Ben Greear wrote:
    > --- linux-2.4.16/drivers/net/eepro100.c Mon Nov 12 18:47:18 2001
    > +++ linux/drivers/net/eepro100.c Tue Dec 18 11:36:11 2001
    > @@ -510,12 +510,12 @@
    > static const char i82557_config_cmd[CONFIG_DATA_SIZE] = {
    > 22, 0x08, 0, 0, 0, 0, 0x32, 0x03, 1, /* 1=Use MII 0=Use AUI */
    > 0, 0x2E, 0, 0x60, 0,
    > - 0xf2, 0x48, 0, 0x40, 0xf2, 0x80, /* 0x40=Force full-duplex */
    > + 0xf2, 0x48, 0, 0x40, 0xfa, 0x80, /* 0x40=Force full-duplex */
    > 0x3f, 0x05, };
    > static const char i82558_config_cmd[CONFIG_DATA_SIZE] = {
    > 22, 0x08, 0, 1, 0, 0, 0x22, 0x03, 1, /* 1=Use MII 0=Use AUI */
    > 0, 0x2E, 0, 0x60, 0x08, 0x88,
    > - 0x68, 0, 0x40, 0xf2, 0x84, /* Disable FC */
    > + 0x68, 0, 0x40, 0xfa, 0x84, /* Disable FC */
    > 0x31, 0x05, };

    hmmm. hmmm. hmmm.

    I am sorely tempted to drop this patch, simply because it's changing one
    magic number to another. One key question I have is, what the fsck does
    this patch really do??? If it turns on VLAN [de-]tagging
    unconditionally, for example, that's unacceptable.

    Comments and insight requested, and appreciated.

    Jeff


    --
    Jeff Garzik |
    Building 1024 |
    MandrakeSoft | Choose life.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:24    [W:0.025 / U:30.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site