[lkml]   [2002]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Various 802.1Q VLAN driver patches. [try2]
On Fri, Mar 01, 2002 at 03:51:00PM -0500, Jeff Garzik wrote:
> >
> > > 3) 3c59x needs real dev->change_mtu support. This patch provides the
> > > info needed to do that... but doesn't do that.
> > Intentionally, as this has nothing to do with VLAN support.
> It does, but not directly. The infrastructure for VLAN and changing MTU
> share common elements, so both should be merged at the same time.

OK, from the chip driving side, yes, but not from the network stack
side, as noted by Ben.

> This is ESPECIALLY key with 3c59x, because we are turning on support for
> large frames, not specifically VLAN. That is obviously the same
> operation as changing MTU to a larger, non-standard one, and so should
> not be treated as something vlan-specific.
> Thanks much for the patch, whoever the author(s) were though...

It was me actually ;-)

> it
> provides the necessary reference information to modify 3c59x for these
> things I describe, and also provide the framework for

When doing the 3c59x modifications, please note the comment above

| Note that this must be done after each RxReset due to some backwards
| compatibility logic in the Cyclone and Tornado ASICs */

The "backwards compatibility logic" mentioned there refers to that
Cyclone and Tornado cards will reset MaxPktSize to standard ethernet
or FDDI MTU (as determined by the allowLargePackets flag) on every

> Early next week, I will likely make a bombing run through several
> drivers, fixing up the large frame and MTU issues. That should be
> enough for software VLAN.


Andreas Ferber - dev/consulting GmbH - Bielefeld, FRG
+49 521 1365800 - -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:24    [W:0.062 / U:6.420 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site