lkml.org 
[lkml]   [2002]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Various 802.1Q VLAN driver patches. [try3]
Ben Greear wrote:
> --- linux/drivers/net/tulip/interrupt.c Fri Nov 9 22:45:35 2001
> +++ linux.dev/drivers/net/tulip/interrupt.c Tue Dec 11 09:24:36 2001
> @@ -128,8 +128,8 @@
> dev->name, entry, status);
> if (--rx_work_limit < 0)
> break;
> - if ((status & 0x38008300) != 0x0300) {
> - if ((status & 0x38000300) != 0x0300) {
> + if ((status & (0x38000000 | RxDescFatalErr | RxWholePkt)) != RxWholePkt) {
> + if ((status & (0x38000000 | RxWholePkt)) != RxWholePkt) {
> /* Ingore earlier buffers. */
> if ((status & 0xffff) != 0x7fff) {
> if (tulip_debug > 1)
> @@ -155,10 +155,10 @@
> struct sk_buff *skb;
>
> #ifndef final_version
> - if (pkt_len > 1518) {
> + if (pkt_len > 1522) {
> printk(KERN_WARNING "%s: Bogus packet size of %d (%#x).\n",
> dev->name, pkt_len, pkt_len);
> - pkt_len = 1518;
> + pkt_len = 1522;
> tp->stats.rx_length_errors++;
> }


Tulip handles fragmented packets by choking hard. I'll probably copy
the fragmented-packed slow path from 8139cp.c, which will change this
patch immensely.

The REAL vlan tulip patch will look almost exactly like the 8139cp patch
in 2.5.6-pre2.

Jeff




--
Jeff Garzik |
Building 1024 |
MandrakeSoft | Choose life.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.056 / U:19.092 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site