lkml.org 
[lkml]   [2001]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: PATCH - gameport_{,un}register_port must be static when inline
On Thursday October 4, kaos@ocs.com.au wrote:
> On Thu, 4 Oct 2001 14:19:13 +1000 (EST),
> Neil Brown <neilb@cse.unsw.edu.au> wrote:
> >Linus,
> > 2.4.11-pre2 wont compile with some combinations of sound card drivers
> > if CONFIG_INPUT_GAMEPORT is not defined, as every driver than include
> > gameport.h causes "gameport_register_port" to be defined as a symbol
> > and there is a conflict.
> >
> > This patch makes the relevant inline functions "static" to avoid this
> > problem.
>
> Please don't. This was fixed in the -ac trees several weeks ago, the
> correct fix is to move the input rewrite from -ac to Linus's tree.
> That is up to the maintainer, Vojtech Pavlik.

Are you sure? 2.4.10 seems to have a big input rewrite, and
patch-2.4.10-ac4 doesn't change gameport.h and makes only minimal
changes to esssolo1.c, one of the drivers in question.

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:17    [W:0.111 / U:5.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site