Messages in this thread |  | | From | Neil Brown <> | Date | Thu, 4 Oct 2001 15:32:54 +1000 (EST) | Subject | Re: PATCH - gameport_{,un}register_port must be static when inline |
| |
On Thursday October 4, kaos@ocs.com.au wrote: > On Thu, 4 Oct 2001 15:04:39 +1000 (EST), > Neil Brown <neilb@cse.unsw.edu.au> wrote: > >Are you sure? 2.4.10 seems to have a big input rewrite, and > >patch-2.4.10-ac4 doesn't change gameport.h and makes only minimal > >changes to esssolo1.c, one of the drivers in question. > > http://marc.theaimsgroup.com/?l=linux-kernel&m=99419452230792&w=2, find > gameport. It was finally fixed in 2.4.5-ac17.
This doesn't negate the fact that it *is* broken in linus-latest, and it *isn't* fixed in alan-latest.
Try compiling a kernel with (at least)
# CONFIG_INPUT_GAMEPORT is not set CONFIG_SOUND=y CONFIG_SOUND_ESSSOLO1=y CONFIG_SOUND_ES1370=y
and see what I mean.
I get:
ld -m elf_i386 -r -o sounddrivers.o soundcore.o es1370.o esssolo1.o maestro.o maestro3.o ac97_codec.o esssolo1.o: In function `gameport_register_port': esssolo1.o(.text+0x6d60): multiple definition of `gameport_register_port' es1370.o(.text+0x7ea4): first defined here esssolo1.o: In function `gameport_unregister_port': esssolo1.o(.text+0x6d64): multiple definition of `gameport_unregister_port' es1370.o(.text+0x7ea8): first defined here
NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |