lkml.org 
[lkml]   [2001]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PLEASE-TESTME] Zerocopy networking patch, 2.4.0-1
   Date: Tue, 9 Jan 2001 11:31:45 +0100
From: Christoph Hellwig <hch@caldera.de>

Yuck. A new file_opo just to get a few benchmarks right ... I
hope the writepages stuff will not be merged in Linus tree (but I
wish the code behind it!)

It's a "I know how to send a page somewhere via this filedescriptor
all by myself" operation. I don't see why people need to take
painkillers over this for 2.4.x. I think f_op->write is stupid, such
a special case file operation just to get a few benchmarks right.
This is the kind of argument I am hearing.

Orthogonal to f_op->write being for specifying a low-level
implementation of sys_write, f_op->writepage is for specifying a
low-level implementation of sys_sendfile. Can you grok that?

Linus has already seen this. Originally he had a gripe because in an
older revision of the code used to allow multiple pages to be passed
in an array to the writepage(s) operation. He didn't like that, so I
made it take only one page as he requested. He had no other major
objections to the infrastructure.

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:52    [W:0.202 / U:9.992 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site