lkml.org 
[lkml]   [2000]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: flags_t
Hi,

> Roman> If that flag ends up in a structure, it's a bug.
>
> Why? Most of the time you keep it locally, but still.

You have to keep locally all the time, putting it into a structure riscs
that the flags are "saved" for too long, see also the sparc restrictions
on that.

> No it ruins readability since you suddenly can no longer see what type
> of object you are actually dealing with.

So what? In this case it's absolutely unnecessary to know the type, only
save_flags/restore_flags have any business with it. It could also be
structure to possibly store some more information and the user shouldn't
care at all.

bye, Roman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.025 / U:2.120 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site