lkml.org 
[lkml]   [2000]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
Subjectflags_t
From

I have always been annoyed by the fact that save/restore_flags save/restore the
flags using an unsigned long variable. I think it would be clearer to use

typedef struct { unsigned long _flags; } flags_t;

or something like that.

Also, I've seen people confused by the "pass by reference" conventions of both
functions. It might be remotely useful to change it to a true function-like
style passing a pointer to the variable instead.

--
Cesar Eduardo Barros
cesarb@nitnet.com.br
cesarb@dcc.ufrj.br
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.065 / U:4.268 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site