Messages in this thread |  | | Date | Wed, 23 Aug 2000 15:54:54 -0300 | Subject | flags_t | From | Cesar Eduardo Barros <> |
| |
I have always been annoyed by the fact that save/restore_flags save/restore the flags using an unsigned long variable. I think it would be clearer to use
typedef struct { unsigned long _flags; } flags_t;
or something like that.
Also, I've seen people confused by the "pass by reference" conventions of both functions. It might be remotely useful to change it to a true function-like style passing a pointer to the variable instead.
-- Cesar Eduardo Barros cesarb@nitnet.com.br cesarb@dcc.ufrj.br - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |